Lodash: Remove from block editor reducer #46656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +11 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/lodash-block-editor-reducer
branch
from
4da54c1 to
26165e5
Compare
ntsekouras
approved these changes
Dec 20, 2022
ntsekouras
force-pushed
the
remove/lodash-block-editor-reducer
branch
from
26165e5 to
5f8c580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.omit()and_.isEmpty()from theblock-editorreducer. There are a few usages in that package and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using destructuring with rest properties to get rid of
omit()and anArray.prototype.filter()for the instance that uses an array to omit. For theisEmpty(), since it's an object, we convert to an array withObject.values()and use.lengthto check if it's an empty object.Testing Instructions
Verify all checks are still green. The changes are covered by unit tests: