Block Editor: Optimize useAvailableAlignments performance
#46655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
youknowriad,
jsnajdr,
flootr and
ntsekouras
|
Size Change: +16 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
@tyxla, what theme were you using to test this scenario? |
Twenty Twenty-Two v1.3, testing in the post editor. |
tyxla
force-pushed
the
optimize/use-available-alignments-array
branch
from
e855c83 to
14687c0
Compare
ntsekouras
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR optimizes the performance of the
useAvailableAlignmentshook by returning the same array instead of a new one whenever we have no available alignments.Why?
When we render on a theme that supports no alignments, we'll trigger additional rerenders because we return a new array every time.
How?
This PR alters the
useAvailableAlignmentshook to always return the same empty array in that scenario.Testing Instructions
nonealignment option #35822 still work.