Block Editor: Make URLPopover tests more precise
#46654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
jsnajdr
approved these changes
Dec 19, 2022
| * @param {HTMLElement} element Element to start with. | ||
| * @return {HTMLElement|null} Popover element, or `null` if not found. | ||
| */ | ||
| function getWrappingPopoverElement( element ) { |
There was a problem hiding this comment.
Maybe it's time to finally extract this to some common helper? 🙂
tyxla
force-pushed
the
improve/url-popover-tests-act
branch
from
3973d53 to
a302495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the
URLPopovertests to actually wait for the popover to be positioned, instead of waiting for the next event loop tick.Why?
This makes the test more comprehensible as it clearly expresses the intention of waiting until the popover has already been positioned.
How?
We're using the
toBePositionedPopovermatcher that we've been using for other tests.Testing Instructions
Verify tests pass:
npm run test:unit packages/block-editor/src/components/url-popover/test/index.js