Move wordcount to the top of the outline #46648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +51 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
I pushed a small fix to simplify some of the CSS to use gap instead of nth-child paddings, and remove width and height values which weren't needed. It fixes an issue with plugins that output this blanket CSS: The above would result in this: |
jasmussen
requested review from
a team,
talldan and
Mamaduka
and removed request for
a team
Mamaduka
approved these changes
Dec 21, 2022
|
While we're here, would it be worth centrally aligning the outline description / image? At the moment it's not immediately obvious that it's informational, it feels a bit like part of the UI.
|
|
Thanks for the review! I think it can make sense to vertially align the image, but I'd love for it to be explored separately. Going to land this one for now. |
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The list view has merged with the outline, and moved the doc meta information to the bottom:
This PR moves the meta information back to the top:
Why?
This is in response to some feedback that it can be hard to find: Automattic/wp-calypso#70094
Testing Instructions
Test the list view > outline, and observe the meta information (word count, etc.) is now at the top of the container.