Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note to register_block_pattern_category() #46628

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

websitegenii
Copy link
Contributor

Added a note to the register_block_pattern_category() stating that the category will not show unless a pattern has been assigned to that category.

What?

Adding a note to help new users adding a custom category that their code is most likely working but if they don't have a pattern assigned to that category it is not showing.

Why?

It is confusing when you add your custom category and no category shows up, questions arise too if you did it correctly.

How?

Adding a note to help troubleshooting.

Testing Instructions

There is no testing needed. It's helping troubleshooting.

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

Added a note to the `register_block_pattern_category()` stating that the category will not show unless a pattern has been assigned to that category.
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @websitegenii! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 17, 2022
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit c2e1f5c into WordPress:trunk Dec 28, 2022
@github-actions
Copy link

Congratulations on your first merged pull request, @websitegenii! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 14.9 milestone Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants