Page List: Remove duplicate code #46620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] Page List
scruffian
commented
Dec 16, 2022
| @@ -164,13 +113,7 @@ export default function PageListItemEdit( { context, attributes } ) { | |||
| <ItemSubmenuIcon /> | |||
| </button> | |||
| ) } | |||
| <ul | |||
| className={ classnames( 'submenu-container', { | |||
There was a problem hiding this comment.
I can't see why we need these extra classes so I'm just removing them.
|
Size Change: -218 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
added 2 commits
December 16, 2022 16:11
scruffian
requested review from
tellthemachines and
ajitbohra
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As suggested in #46587, we should reduce the duplicate code here.
This also removes some extra code which I believe was redundant.
Why?
Maintainability.
How?
Extract two functions to a utils file.
Testing Instructions
I have also removed some code which handled a couple of cases because I believe its covered by other code.
In the editor, select a navigation link which is deeply embedded in a submenu stack.
When you mouse off the link, the menu should remain open
(Note that this does not yet work for Page List items, this is a separate bug - Page List: Keep submenu open when child block is selected. #46621)
Create a page that has a navigation with a Page List block inside it
View the page in the frontend of your site
Resize your browser window to the point where the navigation collapses to a hamburger menu
Open the overlay using the hamburger menu
Check that the Page List items are all visible.
Testing Instructions for Keyboard
As above.