Improve empty menu state in nav off-canvas editor #46602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Block] Navigation
ajlende
requested review from
draganescu,
scruffian,
getdave,
SaxonF and
MaggieCabrera
|
@SaxonF I know this isn't much like the designs you shared in the issue, but I think the simple approach of adding a note next to the button won't be as jarring of a change when you add the first item. I can absolutely go ahead and build something closer to the original designs or iterate on this one if you think it needs to change, but I wanted to hear your thoughts on this first. |
|
Size Change: +82 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
I like it! There's a bit of a spacing issue around the [+] but I think we can deal with that when we work on #46359 |
scruffian
force-pushed
the
fix/offcanvas-empty-menu-state
branch
from
0e55e31 to
4eeff39
Compare
scruffian
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a note to the empty nav list to provide some direction.
Why?
Fixes #46202
How?
Adds a note when there are no children for the nav block.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast