Verse: Prevent default styles overriding theme.json font family #46560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +36 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Dec 19, 2022
glendaviesnz
force-pushed
the
fix/verse-default-font-family-style
branch
from
e78285b to
1a4b734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46181
What?
Prevents default block styles from overriding theme.json set font family.
Why?
The block's default style's purpose appears to be to remove the standard
premonospaced font and match the primary font family. It isn't intended to override anything set by the theme.json.How?
Lowers the specificity of the font family style.
Alternative Approaches
pre.wp-block-verseselector in the default styles. This would have a more wide-ranging impact, so I opted for a simpler tweak to the block's CSS.__experimentalStyleproperty within the block.json. The catch here is that these styles aren't included for classic themes.Testing Instructions
Testing Instructions for Keyboard
No changes to the UI.
Screenshots or screencast