-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying the npm package release process for the RC release. #46555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@@ -34,6 +34,10 @@ To release a release candidate (RC) version of the plugin, enter `rc`. To releas | |||
|
|||
This will trigger a GitHub Actions (GHA) workflow that bumps the plugin version, builds the Gutenberg plugin .zip file, creates a release draft, and attaches the plugin .zip file to it. This part of the process typically takes a little under six minutes. You'll see that workflow appear at the top of the list, right under the blue banner. Once it's finished, it'll change its status icon from a yellow dot to a green checkmark. You can follow along in a more detailed view by clicking on the workflow. | |||
|
|||
#### Publishing the @wordpress packages to NPM | |||
|
|||
As part of the release candidate (RC) process, all of the `@wordpress` packages are published to NPM. You may see messaging after the ["Build Gutenberg Plugin Zip" action](https://github.com/WordPress/gutenberg/actions/workflows/build-plugin-zip.yml) action has created the draft release that the ["Publish npm packages"](https://github.com/WordPress/gutenberg/actions/workflows/publish-npm-packages.yml) action requires someone with appropriate permissions to trigger the action. This is not the case as this process is automated and it will automatically run after the release notes are published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the case as this process is automated and it will automatically run after the release notes are published.
@ryanwelcher I found it hard to understand this last part. Is there any further clarification that can be added?
Maybe something like "As the release coordinator you don't need to take any action"?(this is my interpretation of what the sentence means, but I wasn't sure).
I'm looking to update the release docs at the moment, so let me know and I can include a small update to this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@talldan you are correct. Feel free to make any clarifications you think are appropriate Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I made some changes here
What?
While running through the process to release the 14.8 RC, there was some confusion around publishing the npm packages. Once the “Build Gutenberg Plugin Zip" action had been completed and created the release notes draft, there was some messaging that the "Publish npm package" action required someone with correct permissions to trigger it.
This is not the case as the action is run after the release notes are published.
This PR adds a section to the release instructions to clarify this process.