Add a performance metric to measure typing within containers #46529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
This PR right now includes the fix from #46527 so the results are very visible for this new metric compared to trunk.
|
youknowriad
force-pushed
the
add/typing-container-metric
branch
from
66d1feb to
6d4e56f
Compare
|
The fix is now in trunk, so I've rebased this and now the metric should be stable compared to trunk. |
tellthemachines
approved these changes
Dec 14, 2022
| it( 'Typing within containers', async () => { | ||
| // Measuring block selection performance. | ||
| await createNewPost(); | ||
| await loadHtmlIntoTheBlockEditor( |
There was a problem hiding this comment.
Would it make sense to instead add this test in another describe, so we don't have to go through the setup steps twice? I can't think offhand of any other container-specific tests we might want to run but it's possible there may be others in the future.
There was a problem hiding this comment.
I thought about this a bit and I'm not entirely sure what's the best solution here. Ideally each it is independent. Right now, some of them are:
- typing in container, selecting blocks as both create new posts in the beginning
- the remaining ones are not independent in the sense that they use whatever is loaded before the test starts (and it seems to be different across metrics depending on where they are placed).
So I do think there's something to be done to improve how things are organized and make it consistent but let's leave this for its dedicated PR and address it for all the tests and not just this particular one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #46527
What and wy?
This PR adds a performance metric that serves to measuring typing with containers as typing at the root level can remain stable while this degrades (see #46527)
To test you can try running
npm run test:performance packages/e2e-tests/specs/performance/post-editor.test.jslocally or you can take a look at the performance job on this PR.