Comments Block: Remove unnecessary editorStyle
prop in legacy metadata
#46514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR removes an
editorStyle
property defined in the legacy Post Comments block's metadata.Reasons:
editor_style
instead.Note that nothing was going wrong from the user's perspective, so this fix could be considered a code-quality fix.
How?
Simply removing the offending line of code. 🙂
Testing Instructions
3.1. checking the class used by the rendered element (it should be
wp-block-comments
) or3.2. opening the code editor (the block markup should be
<!-- wp:comments {"legacy":true} /--></div>
editor.css
and are applied correctly, with and without this PR.Screenshots or screencast
This is how it should look, before and after.