Lodash: Refactor editor away from _.find()
#46464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
tyxla
commented
Dec 12, 2022
| @@ -122,8 +122,7 @@ export function PageAttributesParent() { | |||
| const opts = getOptionsFromTree( tree ); | |||
|
|
|||
| // Ensure the current parent is in the options list. | |||
| const optsHasParent = find( | |||
| opts, | |||
| const optsHasParent = opts.find( | |||
There was a problem hiding this comment.
opts will always be an array:
| @@ -69,8 +64,7 @@ export default function PostFormat() { | |||
| supportedFormats?.includes( format.id ) || postFormat === format.id | |||
| ); | |||
| } ); | |||
| const suggestion = find( | |||
| formats, | |||
| const suggestion = formats.find( | |||
There was a problem hiding this comment.
POST_FORMATS are always an array:
gutenberg/packages/editor/src/components/post-format/index.js
Lines 17 to 29 in 2dea6e8
| @@ -21,7 +21,7 @@ const getSuggestion = ( supportedFormats, suggestedPostFormat ) => { | |||
| const formats = POST_FORMATS.filter( ( format ) => | |||
| supportedFormats?.includes( format.id ) | |||
| ); | |||
| return find( formats, ( format ) => format.id === suggestedPostFormat ); | |||
| return formats.find( ( format ) => format.id === suggestedPostFormat ); | |||
There was a problem hiding this comment.
POST_FORMATS are always an array:
gutenberg/packages/editor/src/components/post-format/index.js
Lines 17 to 29 in 2dea6e8
| @@ -50,7 +50,7 @@ const isSameTermName = ( termA, termB ) => | |||
| const termNamesToIds = ( names, terms ) => { | |||
| return names.map( | |||
| ( termName ) => | |||
| find( terms, ( term ) => isSameTermName( term.name, termName ) ).id | |||
| terms.find( ( term ) => isSameTermName( term.name, termName ) ).id | |||
There was a problem hiding this comment.
Always an array:
| @@ -95,7 +95,7 @@ export function sortBySelected( termsTree, terms ) { | |||
| * @return {Object} Term object. | |||
| */ | |||
| export function findTerm( terms, parent, name ) { | |||
| return find( terms, ( term ) => { | |||
| return terms.find( ( term ) => { | |||
There was a problem hiding this comment.
Always an array:
| @@ -203,7 +203,7 @@ export function FlatTermSelector( { slug } ) { | |||
|
|
|||
| const newTermNames = uniqueTerms.filter( | |||
| ( termName ) => | |||
| ! find( availableTerms, ( term ) => | |||
| ! availableTerms.find( ( term ) => | |||
There was a problem hiding this comment.
Declared as an array above:
|
Size Change: -25 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.find()from theeditorpackage. There are a few usages in that package and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Array.prototype.find()instead of_.find().Testing Instructions