BlockListAppender: with custom appender, don't react to nested list settings changes #46461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Feature] Inserter
|
Size Change: +11 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Dec 13, 2022
This is hard because you'd have to build the mobile app from this branch and test it. Create a "Columns" block with two columns, and then select one column, and verify that it has a working block inserter (the + icon) in the bottom toolbar:
On the other hand this is exactly what the unit tests are testing, so you might want to trust them and give up manual testing 🙂 |
tyxla
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
This looks great, and tests well in web. Given tests pass, I don't see why it wouldn't work well in RN. I'd be happy to ship it 👍
I'll have to devote half a day to set up my mobile build again, but for now I'll pass on giving this a spin on mobile.
I'll leave it to you @jsnajdr as to whether to wait for an approval from mobile folks or ship immediately.
jsnajdr
force-pushed
the
optimize/block-appender-rerender
branch
from
86baeaa to
f113506
Compare
jsnajdr
force-pushed
the
optimize/block-appender-rerender
branch
from
f113506 to
fa92a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests written with React Testing Library don't like situations where:
Promise.thenhandlerIn such a case the "update not wrapped in
act()" warning is triggered -- something has changed asychronously and the test didn't catch it by waiting for the change to happen.This situation happens when testing the mobile columns block. You create a new column block, synchronously perform the test actions on it (like changing vertical alignment) and then finish the test. However, there is another process going on: the column block initially has no
blockListSettings, andupdateBlockListSettingsdispatch for it gets async scheduled. This dispatch affects rendering of the block inserter (the + icon in the mobile toolbar):Because this inserter asks whether it can insert the default block (
canInsertDefaultBlock). Initially this isfalsebecause the column block doesn't yet have any list settings, and later becomestrue. That leads to rerender of the inserter.But when the inserter is rendered with custom UI (
renderAppender) it doesn't really use thecanInsertDefaultBlockvalue. Therefore, a state update that has no UI effect.This PR fixes that by splitting
BlockListAppenderinto multiple components. The outer checks the custom UI and returns immediately when custom UI is requested. Only when custom UI is not requested, does it render an inner component which does theuseSelectwithcanInsertDefaultBlock.