Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site editor: do not remount iframe #46431

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Site editor: do not remount iframe #46431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/edit-site/src/components/block-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export default function BlockEditor( { setIsInserterOpen } ) {
const {
storedSettings,
templateType,
templateId,
page,
isNavigationSidebarOpen,
canvasMode,
Expand All @@ -71,15 +70,13 @@ export default function BlockEditor( { setIsInserterOpen } ) {
const {
getSettings,
getEditedPostType,
getEditedPostId,
getPage,
__unstableGetCanvasMode,
} = select( editSiteStore );

return {
storedSettings: getSettings( setIsInserterOpen ),
templateType: getEditedPostType(),
templateId: getEditedPostId(),
page: getPage(),
isNavigationSidebarOpen:
select( interfaceStore ).getActiveComplementaryArea(
Expand Down Expand Up @@ -257,8 +254,6 @@ export default function BlockEditor( { setIsInserterOpen } ) {
<BlockEditorKeyboardShortcuts.Register />
<BackButton />
<ResizableEditor
// Reinitialize the editor and reset the states when the template changes.
key={ templateId }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a reset in size is needed, we should be doing it inside the ResizableEditor components and not remount the whole tree.

enableResizing={ enableResizing }
height={ sizes.height }
>
Expand Down