Mobile: Updates packages to not use Git HTTPS URLs #46422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jsdom-jscore-rn to use the latest version that includes the commit hash we had - react-native-hr to use a fork instead of a git https URL until we create our own component
geriux
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
ryanwelcher
changed the title
ryanwelcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #40540
What?
This PR updates
jsdom-jscore-rnandreact-native-hrdependencies to not use Git HTTPS URLs to unblock upgrading to NPM 8,Why?
In previous efforts to upgrade to Node 16 and NPM 8, there was an issue with dependencies that use Git HTTPS URLs.
How?
For
jsdom-jscore-rnit now uses the latest released package version that includes the commit hash we had referenced.For
react-native-hrit points to our fork instead of a Git HTTPS URL until we create our own component.Testing Instructions
CI checks should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A