Template Parts: Fix modal search stacking context #46421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Thanks for the PR George! Can you take a look to apply the fix in |
|
@ntsekouras, the replacement action uses the same modal, so there is no need for additional changes. |
jasmussen
approved these changes
Dec 9, 2022
Hm... For me it didn't work(Chrome and site editor).. Let me try again. |
ntsekouras
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes the stacking context of the Search component in the "Choose template part" modal.
Why?
I noticed that I couldn't focus on searching while scrolling through the template parts. Clicking on the search field was selecting the template part.
How?
Updating the
z-indexto 2 seems to resolve the issue.Testing Instructions
Screenshots or screencast
CleanShot.2022-12-09.at.12.10.42.mp4