-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Parts: Remove unnecessary 'useCallback' #46420
Merged
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Block] Template Part
Affects the Template Parts Block
labels
Dec 9, 2022
Mamaduka
requested review from
ntsekouras and
youknowriad
and removed request for
ajitbohra
December 9, 2022 07:59
Size Change: -7 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Template Part
Affects the Template Parts Block
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes unnecessary memoization of the
onTemplatePartSelect
callback.Why?
The
onTemplatePartSelect
function wasn't passed to any hook or memoized component that might require a stable reference.Testing Instructions
Confirm that template part selection from the placeholder state works as before.