Adds page list as child of submenu #46414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +235 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
draganescu
changed the title
draganescu
changed the title
draganescu
force-pushed
the
try/page-list-submenu
branch
from
c0817a1 to
52254f4
Compare
|
I keep seeing the issue where a theme that has colors applied to the navigation block won't see them for the submenu with a page list on it. The list items are all missing the classes that would apply them. I tested this with Disco.
|
draganescu
requested review from
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
getdave
reviewed
Dec 14, 2022
packages/block-library/src/navigation/edit/menu-inspector-controls.js
Outdated
Show resolved
Hide resolved
|
I had to restart my env cause I was still seeing the double ul. Now I don't but I'm getting this on the site editor and I'm not sure if it's unrelated. It only happens when I hover and open the submenus on the editor. |
scruffian
force-pushed
the
try/page-list-submenu
branch
from
ef8d9f9 to
a4aebe2
Compare
getdave
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Some 🙏. Otherwise looks good.
I'll defer to @MaggieCabrera and others on the styling side of things.
|
I get this message in the editor: |
|
In the page list, if there are submenus, they don't open unless I select the page list block itself, which feels a bit strange. |
|
Another thing I noticed - the overlay colors don't always seem to be inherited: 
|
scruffian
force-pushed
the
try/page-list-submenu
branch
from
57085f5 to
9ce2646
Compare
scruffian
approved these changes
Dec 15, 2022
styling bug of page list Co-authored-by: Dave Smith <[email protected]> Co-authored-by: Maggie <[email protected]> Co-authored-by: Ben Dwyer <[email protected]>
Co-authored-by: Ben Dwyer <[email protected]> Co-authored-by: Maggie <[email protected]>
draganescu
force-pushed
the
try/page-list-submenu
branch
from
9ce2646 to
cce7118
Compare
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #46413 - allows the page list block to be used inside submenus of a navigation block.
Why?
Because now that Page list is filterable on parent it can be used to create self updating sections of the navigation.
How?
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
page-list-in-menu.mp4