Shared standard Link UI component between Nav Link and Submenu blocks #46370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
getdave
requested review from
draganescu,
scruffian,
MaggieCabrera and
ajlende
|
Size Change: -340 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #46031 we refactored all the elements relating to creation and managing Links in the Nav Link block into a standalone component.
This PR uses the same component in the Submenu block to DRY up this repeated code and logic.
Closes #46207
Why?
As the Submenu block utilises the same code pretty much verbatim it makes sense to share that file between the two blocks.
How?
Imports the component from the Nav Link block into the Nav Submenu block.
Question: is this "allowed"?
Testing Instructions
Add a submenu block and interact with the link creation elements of the block. Check
Should behave exactly as per
trunk.Testing Instructions for Keyboard
Screenshots or screencast