Block Editor: revert deoptimization useNestedSettingsUpdate #46350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Settings actions"
|
Size Change: +74 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
This looks good to me but what's weird to me is that when I introduced this batching, it had a huge impact on first block load that was noticeable in the graph very easily. But the React 18 upgrade PR didn't seem to have the opposite effect. Now I'm wondering if there was another change that made this optimization unnecessary. (but I can't think of anyway of avoiding the issue we had 🤔)
The initial load of the |
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…Settings actions" (WordPress#46350)
ryanwelcher
added
[Package] Block editor
ryanwelcher
changed the title
ryanwelcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the deoptimization of
useNestedSettingsUpdatethat was done during the React 18 migration (#45235).Mysteriously, after the revert there are no failed unit or e2e tests. Previously, in the #45235 branch, I had to modify
useNestedSettingsUpdateto get rid of "update not wrapped inact()" warnings. These warnings appeared when testingpackages/block-libraryblocks with inner blocks, likecolumns,listorbuttons.I'm not sure why the tests are now green without any extra effort. The memoization fixes for
innerBlocksin #46226 might be the cause.