Child Layout controls: Fix help text for height #46319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Feature] Layout
|
Size Change: +10 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix help text for child layout size controls in the vertical orientation (e.g. Stack block) so that the help text refers to 'height' instead of 'width' when
Fixedis selected.Why?
Looks like we missed adding in a conditional for the help text based on orientation.
How?
In the
helpTextfunction, also pass in the parent layout so that we can determine the orientation. Default to horizontal.Testing Instructions
Fit,Fill, andFixedall read correctly.Fixedrefers towidth.Screenshots or screencast