Social Links mobile test: wait for URL bottom sheet to appear #46308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
ryanwelcher
added
Mobile App - i.e. Android or iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a "not wrapped in
act()" warning when testing adding a social icon block on mobile.The test adds an Amazon social icon, then verifies that the edited HTML is as expected: contains a
core/social-linkblock with aservice: 'amazon'attribute, and emptyurl.But at the moment when the test ends and checks the edited HTML snapshot, the insertion is not yet fully finished: it shows a bottom sheet like this:
Showing this bottom sheet is async, with a
useEffect+queueMicrotaskcombination. Coming from theReactNavigationContainercomponent. And it triggers the "not wrapped inact()" warning.The solution is to wait for the bottom sheet to appear, referencing it with its test ID.