Link UI: Destructure the props earlier in the component #46209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess them as consts
getdave
approved these changes
Nov 30, 2022
|
Size Change: -130 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
DaisyOlsen
added
[Type] Enhancement
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…ess them as consts (WordPress#46209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This destructures the props inside Link UI, so that when we pass them around we can access them as consts directly.
Why?
This makes the code a bit easier to read and also means that if we change the structure of the props in the future we only need to update this one place.
How?
{ destructuring } = propsTesting Instructions
Check that Link UI in the navigation link block and the off canvas editor both function the same as each other.