Navigation Link UI: Try to align both files #46205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
reviewed
Nov 30, 2022
Comment on lines
-168
to
+157
| title: props.link.label && navStripHTML( props.link.label ), | ||
| title: props.link.label && stripHTML( props.link.label ), |
There was a problem hiding this comment.
Noting for posterity that I believe navStripHTML was intended as a short term work around for the fact that stripHTML originally also collapsed leading/trailing whitespace in a given string (due to implementation details).
Whilst that was being resolved I implemented navStripHTML which has nearly identical implementation except it does not run safeHTML over the string. Hopefully that is just an oversight and not a huge problem.
So if there are suddenly bugs with escaping in the Link UI then we know to take a good look at this change.
|
Size Change: +22 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
getdave
reviewed
Nov 30, 2022
| @@ -3,6 +3,7 @@ | |||
| /** | |||
| * WordPress dependencies | |||
| */ | |||
| import { __unstableStripHTML as stripHTML } from '@wordpress/dom'; | |||
There was a problem hiding this comment.
@scruffian I don't understand why but here I didn't need to use the unstable export. But in the Nav Link block I did else it would error.
Any ideas!?
getdave
reviewed
Nov 30, 2022
| @@ -1,6 +1,7 @@ | |||
| /** | |||
| * WordPress dependencies | |||
| */ | |||
| import { __unstableStripHTML as stripHTML } from '@wordpress/dom'; | |||
There was a problem hiding this comment.
Using stripHTML was undefined. Had to use the unstable version. I don't understand how because it seems to be exported as stable...
getdave
approved these changes
Nov 30, 2022
DaisyOlsen
added
[Type] Code Quality
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* Navigation Link UI: Try to align both files * use correct reference to stripHTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two files should be as close to identical as possible. This tries to align them closer.
To test, check that both Link UI components work the same as trunk.