Lodash: Replace _.isEqual() with fastDeepEqual
#46200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
youknowriad,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
tyxla
requested review from
ajitbohra,
noisysocks,
ellatrix,
ZebulanStanphill and
nerrad
as code owners
|
Size Change: +2.55 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
replace/lodash-isequal
branch
from
6af0f6a to
96a68ab
Compare
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* Lodash: Replace _.isEqual() with fastDeepEqual * Update isEqual usage in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.isEqual()and deprecates it, in favor offastDeepEqual.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
fastDeepEqualas a drop-in replacement - in my testing, it appears it's working the same way with various kinds of data types and structures. It also promises to be over 5 times faster than_.isEqual():Testing Instructions