-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint: Fix minor ESLint warning in LinkUI
#46161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Priority] Low
Used to indicate that the issue at hand isn't a top priority to address and can be handled later
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Block library
/packages/block-library
labels
Nov 29, 2022
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
scruffian
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Appreciate you fixing this. Not sure how it's even possible to end up in this situation 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Block library
/packages/block-library
[Priority] Low
Used to indicate that the issue at hand isn't a top priority to address and can be handled later
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on #46160 I noticed a new ESLint warning that we seem to have introduced in #46031. This PR fixes it.
Why?
Ideally, we should have no ESLint warnings in the entire codebase.
How?
I ran
npm run lint:js -- --fix
to auto-fix it.Testing Instructions
Run
npm run lint:js
and verify the warning from the screenshot below is gone.Screenshots or screencast