Block Editor: Fix ESLint warnings in MediaUpload tests
#46035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
jsnajdr,
flootr,
ntsekouras and
brookewp
|
|
ntsekouras
approved these changes
Nov 24, 2022
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on fixing ESLint violations for our
@testing-librarytests, I discovered we have quite a few (~48) ESLint warnings. Many of them can be fixed, and this PR is fixing a few of them.This PR refactors
@wordpress/block-editorMediaUploadcomponent tests to make assertion more explicit, to follow thejest/expect-expectESLint rule.Why?
Ideally, we should have no ESLint warnings in the codebase at all. This PR is a step in that direction.
How?
Since the assertions are inside large complex helper functions to avoid lots of repetition and boilerplate, we're altering the ESLint rule inline to support the additional assertion functions. We're using
assertFunctionNamesfor that, and enabling any function that starts withexpectin this test file to be a valid assertion.Testing Instructions
npm run lint:jsand verify the following warnings no longer appear:Screenshots or screencast