Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug that List block attributes were reset in 6.1.1 #46000

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Fixed a bug that List block attributes were reset in 6.1.1 #46000

merged 2 commits into from
Nov 25, 2022

Conversation

ddryo
Copy link
Contributor

@ddryo ddryo commented Nov 23, 2022

What?

This is a PR that fixes #45987.

How?

Inherited data such as className, fontSize, textColor, etc. that were not inherited in 6.1.1.

Testing Instructions

  1. Prepare an environment with a version of 6.1 or earlier and use the list. (e.g., 6.0.3)
  2. Change the background color and font size of the list block.
  3. Save the article.
  4. Update to 6.1.1 and open the edit window for that article again.

@ddryo ddryo requested a review from ajitbohra as a code owner November 23, 2022 11:33
@codesandbox
Copy link

codesandbox bot commented Nov 23, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] List Affects the List Block labels Nov 23, 2022
talldan
talldan reviewed Nov 24, 2022
View reviewed changes
packages/block-library/src/list/utils.js Outdated
@@ -56,7 +56,8 @@ export function createListBlockFromDOMElement( listElement ) {
}

export function migrateToListV2( attributes ) {
const { values, start, reversed, ordered, type } = attributes;
const { values, start, reversed, ordered, type, ...othorAttrs } =
Copy link
Contributor

@talldan talldan Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here - othorAttrs should be otherAttributes.

@talldan talldan requested a review from ellatrix November 24, 2022 02:25
@ddryo
Copy link
Contributor Author

ddryo commented Nov 24, 2022

@talldan Fixed!

@t-hamano t-hamano mentioned this pull request Nov 24, 2022
Closed
ellatrix
ellatrix approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@talldan talldan merged commit 9aff35e into WordPress:trunk Nov 25, 2022
@github-actions github-actions bot added this to the Gutenberg 14.7 milestone Nov 25, 2022
@talldan talldan added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Nov 26, 2022
@t-hamano t-hamano mentioned this pull request Nov 29, 2022
Closed
@Mamaduka Mamaduka removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Mar 29, 2023
@kmrmohit kmrmohit mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan left review comments

@ellatrix ellatrix ellatrix approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] List Affects the List Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 14.7
Development

Successfully merging this pull request may close these issues.

List block styles will be reset in 6.1.1.
4 participants
@ddryo @talldan @ellatrix @Mamaduka