Components: Remove deprecated calendar help from DateTimePicker
#45999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: -725 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
tyxla
requested review from
noisysocks,
mirka,
ciampo,
flootr,
jsnajdr,
brookewp and
chad1008
tyxla
added
[Type] Enhancement
This was referenced Nov 23, 2022
tyxla
commented
Nov 23, 2022
| @@ -5,6 +5,7 @@ | |||
| ### Enhancements | |||
|
|
|||
| - `TabPanel`: Add ability to set icon only tab buttons ([#45005](https://github.com/WordPress/gutenberg/pull/45005)). | |||
| - `DateTimePicker`: Remove deprecated `__nextRemoveHelpButton` and `__nextRemoveResetButton` ([#45999](https://github.com/WordPress/gutenberg/pull/45999)). | |||
|
@tyxla, our policy on removing deprecated APIs and props has changed recently, so I'm not entirely sure that we can remove these props. Here's a recent example #45195 (comment) and you can find general conversations in this issue #40316. |
5 tasks
|
Thanks for letting me know @Mamaduka! I wonder what alternatives we have? Punt the decision for 6 more months of releases by just bumping the |
|
@Mamaduka would that policy apply also for experimental props like the ones being discussed in this PR?
Off the top of my mind:
|
github-actions
bot
added
the
[Status] In Progress
|
Okay, I've filed #46006 to bump the removal version of the deprecated props. That gives us some time to think about it better while the checks in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the deprecated calendar help functionality from the
DateTimePickerpackage.Why?
The
DateTimePickercalendar help has been deprecated since Version 13.4 and was scheduled to be removed for 14.6.Removing the deprecated props and the related code fixes the Static Analysis check which is currently failing in
trunk.How?
We're removing the deprecated props and related code.
Testing Instructions
npm run storybook:devand verify theDateTimePickercomponent stories look good.