Page List: If no parent page is set, still render all children #45967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…e new parentPageID attribute. Co-authored-by: Ben Dwyer <[email protected]>
draganescu
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
draganescu
approved these changes
Nov 22, 2022
DaisyOlsen
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the condition to display child pages, to assume that NULL is not a valid parentPageID value.
Why?
If no
parentPageIDattribute is set, then we should display all the child pages.How?
Change
!==0to0<. This is maybe not ideal, as it makes some assumptions about the default value of parentPageID. Alternatively we could add an is_empty check.Testing Instructions