Navigation List view: Include offcanvas specific styles #45963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
draganescu
approved these changes
Nov 22, 2022
getdave
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Thank you for pulling this PR out for us 🙏
It's required because on trunk the styles for the offcanvas list view weren't being included even though the style.scss file was in the file tree.
We should be extremely careful and selective about the styles we introduce into this custom file as anything we do may need to be merge back into the core list view later.
packages/block-editor/src/components/off-canvas-editor/style.scss
Outdated
Show resolved
Hide resolved
getdave
requested changes
Nov 22, 2022
There was a problem hiding this comment.
I'm blocking this merge temporarily because I'd like the changes in #45963 (comment) to be actioned prior to merge.
getdave
approved these changes
Nov 22, 2022
| height: 36px; | ||
| } | ||
|
|
||
| //Styles for off-canvas editor, remove this line when you add some css to this file! |
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
DaisyOlsen
added
[Block] Navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR cherry picks a273d65 from #45947 so the new off canvas editor includes its own CSS file
Why?
Originally we were duplicating the list view code and not including the copied scss file. We are cleaning up here and including it.