Prevent edit-post from being loaded in edit-site #45895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
|
|
Size Change: +13.5 kB (+1%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Thanks for working on this. I had been looking for the source of this but you found it faster. I get this error when I open the site editor:
Also, please can you explain why it's OK for the native files to load this dependency but not the web editor? Thanks again! |
Native files have their own build scripts... I think they probably bundle everything into a single script but to be honest it's a bit out of my expertise. I think conceptually, the issue is the same there though.
yeah good catch, I'll fix it later. |
|
Fixed the JS error @scruffian I'm still seeing some errors on the site editor myself but I'm also seeing them on trunk (and might be something that is only showing up for me) |
scruffian
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed that when loading the site editor, the edit-post script was also being loaded there. This loads useless kbytes into the site editor and might have some unexpected consequences (like running side effects in the edit-post script).
How?
The problem was that the block-directory package has a plugin that is specific to edit-post but it was importing the package directly causing a wp dependency to be added to the script. This PR uses the global variable directly and also adds some lint rules to prevent top level packages from being imported in other packages.
Note that there are some remaining imports in "native" files, I preferred to leave these untouched for now, folks from the mobile team might know better what's the best approach there.
Testing Instructions
1- load the site editor
2- Ensure that the edit-post script is not loaded.