[Query Loop Block ] Only show the Filters panel when there are allowed controls that need to be displayed #45869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +27 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Nov 30, 2022
There was a problem hiding this comment.
Thanks for the PR @ryanwelcher! Some small changes and we can land.
packages/block-library/src/query/edit/inspector-controls/index.js
Outdated
Show resolved
Hide resolved
|
@ntsekouras this is ready for review. Thanks! |
… for each section.
ntsekouras
force-pushed
the
fix/query-loop-block-filters
branch
from
6894379 to
4fa1681
Compare
ntsekouras
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR addresses #45864 by checking that allowedControls contain at least one of the items that exist under the Filters panel before rendering it.
Why?
Without this check, it is possible to render an empty Filters panel
Testing Instructions
See steps to reproduce in #45864