Navigation: Add a new ManageMenusButton component #45782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think the |
|
Oops, sorry. Fixed now! |
|
Size Change: +12 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Nov 15, 2022
packages/block-library/src/navigation/edit/manage-menus-button.js
Outdated
Show resolved
Hide resolved
Mamaduka
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow up from #45769, creating the new component in a different file to help with readability and performance.
Why?
By extracting a disabled prop we can ensure that the component won't rerender unless necessary.
How?
Put the component in a new file, extract the logic to determine whether to the button is disabled, and wrap it in memo.
Testing Instructions
Check that the "manage menus" button in the inspector controls for the Navigation block, works as before.