Navigation: Reduce duplicate code #45779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +53 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
ajlende
approved these changes
Nov 15, 2022
ramonjd
reviewed
Nov 15, 2022
| ) } | ||
| </PanelBody> | ||
| </InspectorControls> | ||
| <MenuInspectorControls currentMenuId={ null } /> |
There was a problem hiding this comment.
Is the currentMenuId prop needed if the value is null?
|
I think I'm looking at the right thing 😄 Seems to work 👍 Just needs a rebase
|
scruffian
force-pushed
the
update/navigation-reduce-duplicate-code
branch
from
666e5ea to
91e424a
Compare
draganescu
force-pushed
the
update/navigation-reduce-duplicate-code
branch
from
91e424a to
74f8eaa
Compare
draganescu
approved these changes
Nov 16, 2022
getdave
approved these changes
Nov 16, 2022
| <p>{ __( 'Select or create a menu' ) }</p> | ||
| ) : ( | ||
| <OffCanvasEditor | ||
| blocks={ innerBlocks } |
There was a problem hiding this comment.
It would be nice if the props were encapsulated inside the component in order that it will be easier to:
- reason about
- refactor later into a separate file
| currentMenuId={ currentMenuId } | ||
| /> | ||
| <ManageMenusButton | ||
| disabled={ isManageMenusButtonDisabled } |
There was a problem hiding this comment.
It would be nice if the props were encapsulated inside the component in order that it will be easier to:
- reason about
- refactor later into a separate file
There was a problem hiding this comment.
what do you mean by encapsulated inside the component?
There was a problem hiding this comment.
I mean you're relying on variables defined outside the component scope. If this component were inside it's own file you couldn't do that. Passing that data via props would be the alternative and makes the component easier to...
reason about
refactor later into a separate file
There was a problem hiding this comment.
Ah yeah, that would be a good next step :)
There was a problem hiding this comment.
Yes agreed. I suppose that's why I'm suggesting doing it now (and every time we refactor to a component) because it makes it easier to take the next step.
| isOffCanvasNavigationEditorEnabled ? null : __( 'Menu' ) | ||
| } | ||
| > | ||
| { isOffCanvasNavigationEditorEnabled ? ( |
There was a problem hiding this comment.
It would be nice if the props were encapsulated inside the component in order that it will be easier to:
- reason about
- refactor later into a separate file
|
@scruffian Sorry to flag this after the merge, but the way the component is defined within another component ( There's no documentation on it, but this twitter convo with some of the React devs has some detail - https://twitter.com/Lilsmooty/status/1575170093566525440. It looks like there's also the |
|
Thanks @talldan. Yes so each time the component renders the inner component is redefined and thus causes state loss and other consequences. I guess this is what was causing my spidey senses to tingle here but I should have followed it through. @scruffian Let's refactor this out to a separate component and pass the props down. |
|
Done here: #45850 |
DaisyOlsen
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This extracts three blocks of almost identical code to a functional component.
Why?
This will help us avoid making changes in one place but not another by mistake.
How?
Simple refactor
Testing Instructions
Enable the off canvas editing experiment and confirm that you see the list view in the sidebar in the same circumstances as before.