Enable page list to expand in list view #45776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
draganescu
added
[Type] Enhancement
|
Size Change: +2.21 kB (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Looks good. Here's normal items:
Here's a page list:
However I'm seeing the page list becoming a vertical list in the canvas in this PR:
Here's the same menu in trunk:
|
draganescu
changed the title
draganescu
requested review from
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
Mamaduka
reviewed
Nov 16, 2022
|
Discussing the bug making the post dirty with @talldan he pointed to how templated blocks work where the template is placed using replace blocks which is a persistent change: This implementation sets the template asynchronously which is after the initial render so the post is marked as dirty, as it should, but not in this case. Dan suggested that to try and manually replace blocks instead of using a template. It remains to be seen which way is best. |
Mamaduka
reviewed
Nov 17, 2022
| @@ -81,6 +82,7 @@ export default function useInnerBlockTemplateSync( | |||
| ); | |||
|
|
|||
| if ( ! isEqual( nextBlocks, currentInnerBlocks ) ) { | |||
| __unstableMarkNextChangeAsNotPersistent(); | |||
There was a problem hiding this comment.
I'm not sure if patching the useInnerBlockTemplateSync hook for a single use case is a good idea 😅
There was a problem hiding this comment.
It's not only this, we've hit this before: see #45843
There was a problem hiding this comment.
Can we remove this from this PR and wait on the decision in #45843?
There was a problem hiding this comment.
I'll try to rebase on that or something. b/c otherwise this PR does not work.
scruffian
reviewed
Nov 17, 2022
scruffian
reviewed
Nov 17, 2022
scruffian
reviewed
Nov 17, 2022
scruffian
reviewed
Nov 17, 2022
scruffian
reviewed
Nov 17, 2022
scruffian
reviewed
Nov 17, 2022
|
I assume you tried using the Page Link block? |
scruffian
reviewed
Nov 17, 2022
scruffian
reviewed
Nov 17, 2022
scruffian
reviewed
Nov 17, 2022
|
Thanks for working on this, it's looking great. I just left a few questions about things I didn't understand. |
2 tasks
getdave
reviewed
Nov 22, 2022
There was a problem hiding this comment.
As things stand I don't think this is working 😞
https://user-images.githubusercontent.com/444434/203301672-d0950170-a1b5-48cb-9d3e-f19384309548.mp4
I cleared all my menus then added a new Nav block.
- a new Nav was automatically created
- I saw a Page List in the offcanvas
- I tried clicking on Page List in the offcanvas but I couldn't seem to select it
- I went to the main List View and clicked on Page List. I was able to selected it.
Basically everything seems out of sync as per the video.
|
Thanks for the testing @getdave 🙇🏻
None seem to be problems of this PR. |
draganescu
force-pushed
the
add/page-list-item
branch
from
72144ea
to
f408ea2
Compare
scruffian
reviewed
Nov 23, 2022
| key={ id } | ||
| className={ classnames( 'wp-block-pages-list__item', { | ||
| 'has-child': hasChildren, | ||
| 'wp-block-navigation-item': isNavigationChild, |
There was a problem hiding this comment.
It seems like there is quite a lot of overlap between this file and the navigation link - they need to share the same layout. Is there anything we can do to ensure they stay in sync?
There was a problem hiding this comment.
I think this has been an issue in core/page-list for a while. The problem has now just moved to the item. Am I right @draganescu ?
There was a problem hiding this comment.
Yes. Page list item is mostly a copy of the old PageItems component used inside the page list block.
There was a problem hiding this comment.
I created a follow up issue for this here: #46050
scruffian
approved these changes
Nov 23, 2022
As long as that works for the Page List (parent) block itself.
The code for this autosave was written specifically to check for a dirty state on the blocks that are pased into the component but it is a little bit "hacky". Did you create an Issue to track this bug? I think that's important 🙏 |
|
What's the status on this one? Blocked due to the sync problems with inner blocks? |
|
Yes, @getdave @scruffian should we merge with the known bug that adding a page list makes the post dirty? Should we wait for #45843 ? |
… json configuration. Co-authored-by: Ben Dwyer <[email protected]>
scruffian
force-pushed
the
add/page-list-item
branch
from
f408ea2
to
86d80e0
Compare
1 task
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #45482
Adds the ability to the page list block to expand in the list view.
Why?
To reflect on the hierarchical structure that we're representing, particularly when the page list is used inside a navigation block.
How?
Add a new Page List Item block that can only appear as a chidl of Page List.
Testing Instructions
Screenshots or screencast
page-list-expands.mp4
Known issues: