Patterns: Ajust the space in the pattern explorer list #45730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Feature] Inserter
|
|
|
Size Change: +10 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
|
Would love a designer eye but looks good to me. |
youknowriad
approved these changes
Nov 14, 2022
|
Looks like a good small iteration, the only niggle being is the right edge of patterns not lining up with the right edge of the close button, as it does in trunk:
I think it should line up, so I'd appreciate not adding the padding on the right. In general I agree there should be padding all around, and I think there's room for a refactor. None of these are necessary for this PR, but just noting that there's a lot of unloved pieces: the hover style shouldn't be a 2px border, it could be a light blue background. The focus style has a very big border radius, it should be 2px and sit closer to the pattern itself. Lots to do! But thank you for the PR, with a right side padding fix, this is a big improvement! |
|
Thank you for the review, @jasmussen ! Is there anything additional about this PR that should be addressed? If so, I would like to include the space issues you mentioned 👍 |
|
The only thing to address is to not add padding on the right side, I think it's better to keep that zero as is. What do you think? |
|
I have not added padding on the right side in this PR. Perhaps you are referring to this scroll bar?
This is displayed in the scrollable area in the Windows OS. This is also true for trunk. In Mac OS, scrollbars do not appear unless scrolled and the bar floats. However, Windows, as you can see, reserves an area the width of the scrollbar. |
|
Ah, my apologies, then merge, thanks again! |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #45701
What?
This PR applies the appropriate spaces in the pattern explorer list. This also fixes that the focus outline gets cut at the top reported in #45701
How?
24pxspace at the top of the pattern list, the same space as the sidebar. This fixes the outline cutoff when focused.32px. This creates an appropriate space between the pattern list and the sidebar.24pxto the bottom of the pattern list, the same as the top. This may not be required, but the bottom of the sidebar also has24pxof space.Screenshots
Before
After