Components: Fix no-container violations in FormGroup tests
#45662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
mirka,
ciampo,
chad1008,
ntsekouras and
brookewp
|
|
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Nov 10, 2022
| <FormGroup labelHidden id="fname" label="First name"> | ||
| <TextInput /> | ||
| </FormGroup> | ||
| ); | ||
|
|
||
| const label = container.querySelector( 'label' ); | ||
| expect( label ).toContainHTML( 'First name' ); | ||
| // @todo: Refactor this after adding next VisuallyHidden. |
There was a problem hiding this comment.
Not sure what this TODO was about, do you think we're safe to remove it?
There was a problem hiding this comment.
I think so. I looked over the history and didn't see an obvious reason for it to be there in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
With the recent work to improve the quality of tests, we fixed a bunch of ESLint rule violations. This PR fixes a few
no-containerrule violations in theFormGroupcomponent.Why?
The end goal is to enable that ESLint rule once all violations have been fixed.
How?
We're refactoring most of the straightforward
querySelector/querySelectorAllinstances to use screen queries instead.Testing Instructions
Verify all tests still pass.