Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Manage Reusable blocks match similar links #45641

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Make Manage Reusable blocks match similar links #45641

merged 1 commit into from
Nov 9, 2022

Conversation

dsas
Copy link
Contributor

@dsas dsas commented Nov 9, 2022

What?

The Manage Reusable blocks link inside the reusable blocks inserter should match other similar links such as 'Explore all patterns' on the pattern inserter.

Why?

User interface consistency. Fixes #45155

How?

This changes a HTML <a> to a <Button variant=secondary /> along with some CSS changes

Testing Instructions

Add a reusable block if you haven't already:

  1. Open Gutenberg post editor
  2. Insert any block
  3. Press the three dots menu of the block and choose 'Create reusable block'
  4. Follow the prompts

Test the change:

  1. Still in the editor, open the inserter (big blue plus at the top left)
  2. In the inserter sidebar, click Patterns and scroll to the bottom, look at the 'Explore all patterns' button
  3. Click 'Reusable blocks' in the inserter sidebar and scroll to the bottom, look at the 'Manage Reusable blocks' button. They should look the same
  4. Click 'Manage Reusable blocks' button it should take you to /wp-admin/edit.php?post_type=wp_block

Screenshots or screencast

Before After
image image

The Manage Reusable blocks link inside the reusable blocks inserter
should match other similar links such as 'Explore all patterns' on the
pattern inserter.
@dsas dsas requested a review from ellatrix as a code owner November 9, 2022 17:51
@codesandbox
Copy link

codesandbox bot commented Nov 9, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vcanales vcanales added the [Feature] Inserter The main way to insert blocks using the + button in the editing interface label Nov 9, 2022
Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@noisysocks noisysocks enabled auto-merge (squash) November 9, 2022 18:02
@noisysocks noisysocks merged commit f6f7afe into WordPress:trunk Nov 9, 2022
@github-actions github-actions bot added this to the Gutenberg 14.6 milestone Nov 9, 2022
@jameskoster
Copy link
Contributor

jameskoster commented Nov 10, 2022

I should have mentioned this on the issue itself, but in addition to the appearance of the button, the positioning should match as well. Would it be possible to add this change in a follow-up?

Edit: nvm, I see Nik has a PR open merged :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs User Documentation Needs new user documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "Manage reusable blocks" link match "Explore all patterns"
5 participants