Layout: replace Justification/Orientation controls with ToggleGroupControl #45637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
|
|
Size Change: -26 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43416
What?
Replacing Justification/Orientation fieldsets with ToggleGroupControl component.
Why?
To improve consistency, reduce code duplication, and add visual/semantic indications that the options are mutually exclusive.
Testing Instructions
Insert a Group block and switch to a Row or Stack layout (flex).
Example HTML
Toggle the justification and orientation controls.
Check that the layout appears as expected in the editor and frontend.
Screenshots or screencast
2022-11-10.04.39.55.mp4