List View: Disable branch expansion when block editing is locked #45541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
jorgefilipecosta,
oandregal and
draganescu
and removed request for
ellatrix
|
Size Change: +34 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Nov 4, 2022
alexstine
reviewed
Nov 5, 2022
There was a problem hiding this comment.
@Mamaduka This is not working for me. I can still expand the group block after locking all blocks within it. I would scan all files for aria-expanded inside list-view, possible you missed something that was added for accessibility that is not clear. There is a lot of hacky magic that went in to this.
|
Thanks for testing, @alexstine! That's the correct behavior for the Group block. The edit locking is only available for the Reusable and Navigation blocks. You can enable it by checking the "Restrict editing" option in the block-locking modal. |
|
@Mamaduka Ah, sorry. I did not completely understand how this feature worked. Testing seems fine. I am now starting to realize though how much we are not exposing to screen readers about the state of the locked blocks though. This is concerning and probably need to make a follow-up plan to fix these. I feel like a broken record, but if there is a locked icon, there is no reason it is not communicated to screen readers. I hope one day, we can get to the point where screen readers get the same info that is available visually. It gets discouraging as things simply move so fast. Details get missed and there are too few of us reviewing these PRs for A11Y compliance. Thanks. |
|
Thanks for the feedback, @alexstine! If you can point me in the right direction, I'll be more than happy to work on a11y improvements for the locked state.
I hope we can improve this soon. |
|
@Mamaduka Essentially, anywhere we're representing a locked state with an icon, we probably need to figure out how to pass that in to a description or label. I'll let you create a tracking issue as you can see where the icons are. Thanks! |
|
Thanks, @alexstine. I'll create the tracking issue. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR disables branch expansion in the "List View" when block editing is locked.
Why?
The users shouldn't be able to select inner blocks when editing is locked for the parent.
How?
I've adjusted the check introduced in #43037. The condition now checks if the content is locked and fallbacks to the block's
canEditvalue, which istrueby default.Testing Instructions
Verify that the list view still works as expected:
Content locked block
Screenshots or screencast