Include TS and JSX files to testing-library lint #45533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Build Tooling
|
|
|
Size Change: +59 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
jsnajdr
reviewed
Nov 4, 2022
| <FlexItem>Item</FlexItem> | ||
| <FlexBlock>Item</FlexBlock> | ||
| </Flex> | ||
| ); |
There was a problem hiding this comment.
Do we really want to render twice here? We probably only want to do the second render, and ignore the one that used to be in beforeEach.
There are many other tests like this. For Flex, Scrollable, Spacer, Surface, ...
There was a problem hiding this comment.
We want to because we intend to compare the snapshots of the two renders (see the toMatchStyleDiffSnapshot call below). That applies to the rest of the tests, or at least most of them.
There was a problem hiding this comment.
Alternatively, we could use asFragment(), but theoretically, it would do the same thing, just with different mechanics.
Lol, let's do this then ✅ 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #45103 and also suggested by @Mamaduka in #45366 (comment).
What?
This PR enables testing library and jest-dom ESLint rules for all
.ts,.tsxand.jsxfiles.Why?
We're aiming to help maintain following the best practices when writing tests with testing-library.
How?
We're enabling the testing library and jest-dom ESLint rules for all
.ts,.tsxand.jsxfiles, including that change to the list of excluded native files.Testing Instructions
Verify all tests are green, and there are no new ESLint errors.