-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Updated names from List View to Document Overview #45524
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
fix/change-list-view-to-doument-overview-aria-labels-and-classes-on-edit-post
Nov 9, 2022
Merged
Fix: Updated names from List View to Document Overview #45524
jorgefilipecosta
merged 1 commit into
trunk
from
fix/change-list-view-to-doument-overview-aria-labels-and-classes-on-edit-post
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
An existing feature does not function as intended
[Status] In Progress
Tracking issues with work in progress
[Package] Edit Post
/packages/edit-post
labels
Nov 3, 2022
jorgefilipecosta
requested review from
ntwb,
nerrad and
ajitbohra
as code owners
November 3, 2022 16:23
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
Size Change: +38 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/change-list-view-to-doument-overview-aria-labels-and-classes-on-edit-post
branch
from
November 3, 2022 18:31
336525d
to
23a3888
Compare
@jorgefilipecosta does this need to be cherrypicked for 14.5? |
jorgefilipecosta
force-pushed
the
fix/change-list-view-to-doument-overview-aria-labels-and-classes-on-edit-post
branch
from
November 9, 2022 17:14
23a3888
to
52d4960
Compare
… classes inside edit-post.
jorgefilipecosta
force-pushed
the
fix/change-list-view-to-doument-overview-aria-labels-and-classes-on-edit-post
branch
from
November 9, 2022 17:58
52d4960
to
055b5d9
Compare
jorgefilipecosta
deleted the
fix/change-list-view-to-doument-overview-aria-labels-and-classes-on-edit-post
branch
November 9, 2022 18:49
I don't think so. |
priethor
added
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
and removed
[a11y] Labelling
labels
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Edit Post
/packages/edit-post
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #44788.
Fixes: #44193
This PR updates the labels from List View to Document Overview inside the edit post.
Thank you, @alexstine, @colorful-tones for the catch and insights!