Lodash: Refactor away from _.reduce()
#45460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
jeremyfelt,
sgomes,
aristath,
jsnajdr,
swissspidy,
opr,
jorgefilipecosta,
chad1008,
ntsekouras,
epiqueras and
fabiankaegy
|
|
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
tyxla
force-pushed
the
remove/lodash-reduce
branch
from
1e05b51 to
17c4bde
Compare
|
Ready for a review! 👀 |
|
Thanks for taking a look, @sgomes 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.reduce()completely and deprecates the method.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing a single use with a simple native
Array.prototype.reduce(). It's straightforward as a few lines above it's easy to see that we're working with an array.The PR is easier to review with whitespace changes ignored.
Testing Instructions
You can test this in a similar way as #43797, but by applying the changes done in this PR instead of the ones suggested there.