-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap the title in the Link Control edit screen #45387
Wrap the title in the Link Control edit screen #45387
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @TimBroddin! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hey @ellatrix, Could you take a look at this small PR? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @TimBroddin, I came across this PR when I was checking PRs that had not been active for a while. This issue appears to have been resolved in #53356, although with a slightly different approach. I would like to close this PR, but I appreciate all of your work. |
What?
This PR makes long titles in the Link Control edit screen wrap to multiple lines.
When a title can't be retrieved through the API, the link's text is shown as the title instead. This causes a very long line that overflows, making the edit & unlink icons inaccessible.
Why?
It partially fixes this issue.
How?
Added
word-break: break-word;
to.block-editor-link-control__search-item-title
Testing Instructions
Screenshots or screencast