Set block attributes to require either type or enum #45365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
block.json
schema to maketype
orenum
be the required options for attributes.Why?
The schema used for
block.json
currently shows an issue for block attributes that use anenum
rather than type. According to the developer handbook, this works as an either or rather than justtype
.How?
Changes
"required": [ "type" ]
into aanyOf
array to require eithertype
orenum
or bothTesting Instructions
block.json
to point to the schema file in this branchtype
ORenum
OR bothScreenshots
Current Schema: error for attribute with only
enum
image_caption
Current Schema: no error for either option