Remove use of set-output in workflows

[desrosj]

What?

Remove the use of set-output commands.

Why?

This command has been deprecated and will be removed in the near future.

For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[alexstine]

@desrosj A few thoughts below.

For the future, these GitHub Workflows should be done differently. Instead of writing a bunch of shell in a run: | statement, it should be moved in to a real #!/bin/bash script. Then other code quality tools such as Shellcheck could be used. Could put all the scripts in .github/scripts. Just something to think about as Gutenberg, Core, and other projects keep using GH Actions.

[desrosj]

Thanks for the review, @alexstine! I made adjustments.

For the future, these GitHub Workflows should be done differently. Instead of writing a bunch of shell in a run: | statement, it should be moved in to a real #!/bin/bash script. Then other code quality tools such as Shellcheck could be used. Could put all the scripts in .github/scripts. Just something to think about as Gutenberg, Core, and other projects keep using GH Actions.

I do agree with moving to real scripts when they span more than a few lines. But I think that separating them into script files could be more confusing in some cases, especially when jobs have multiple steps running bash commands. In general, I think we should try to move towards more atomic steps that perform one operation in our workflows to simplify things as much as possible. It makes it more clear where problems occur, and makes it easier to debug issues.

[alexstine]

LGTM.