Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Title: How to use JavaScript with Gutenberg #45323

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

bph
Copy link
Contributor

@bph bph commented Oct 26, 2022

I heard and read from a few WordPress developers, that the title of this section was misleading. They didn't think they needed to 'get started on JavaScript' and skipped the section during their first round of discovery on how to work with the block editor. They would have shortened their discovery if the title were a bit more descriptive.

heard from a few developers, that the title is not accurate. They didn't think they needed to get started on JavaScript would have shortened their discovery if the title were a bit more descriptive.
@bph bph changed the title Change Title to Getting started with JavaScript and how it is use with WordPress Change Title to Getting started with JavaScript and how it is used with WordPress Oct 26, 2022
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bph Thanks for the PR. Maybe this would be even more clear?

@@ -1,4 +1,4 @@
# Getting Started with JavaScript
# Getting Started with JavaScript and how it is used with WordPress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Getting Started with JavaScript and how it is used with WordPress
# Getting Started with JavaScript and how it is used with Gutenberg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good; or 'the block editor' (instead of Gutenberg... not sure which is preferred nowadays).

@alexstine alexstine added [Type] Enhancement A suggestion for improvement. [Type] Developer Documentation Documentation for developers labels Oct 29, 2022
@bph bph changed the title Change Title to Getting started with JavaScript and how it is used with WordPress Change Title: How to use JavaScript with Gutenberg Nov 9, 2022
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramonjd
Copy link
Member

ramonjd commented Nov 9, 2022

Sorry! Looks like we need to run npm run docs:build on this branch so that it's updated in docs/manifest.json

@bph
Copy link
Contributor Author

bph commented Nov 9, 2022

@ramonjd would help if I push my local manifest.json upstream. 😸

@bph bph enabled auto-merge (squash) November 9, 2022 19:21
@bph bph merged commit 9ef0dd9 into trunk Nov 9, 2022
@bph bph deleted the update-getting-started-withJS branch November 9, 2022 19:24
@github-actions github-actions bot added this to the Gutenberg 14.6 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants