Navigation block: return undefined from useEffect #45239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -7 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Navigationblock has twouseEffectcalls that return eitherfalseor aPromise. React 18 doesn't like that and reports a warning:and then proceeds to call the non-function anyway as a cleanup function, leading to crash. Seems that React 18 is more sensitive to the
useEffectreturn values than previous versions.This PR fixes the
useEffectcalls. I found the issue when debugging e2e test failures in #45235. TheNavigationblock is displayed in the global block inserter and leads to crash when running thee2e test.