Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uploading artifacts even when the tests are successful #45187

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Fix uploading artifacts even when the tests are successful #45187

merged 1 commit into from
Oct 21, 2022

Conversation

kevin940726
Copy link
Member

What?

Fix uploading artifacts even when Playwright tests are successful.

Why?

Saves some bytes.

How?

Only upload the test-results folder and check if it exists.

Testing Instructions

CI should pass and no failure artifacts should be uploaded.

@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Oct 21, 2022
@kevin940726 kevin940726 requested a review from talldan October 21, 2022 03:30
@kevin940726 kevin940726 self-assigned this Oct 21, 2022
alexstine
alexstine reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin940726 Any ideas about this?

.github/workflows/end2end-test-playwright.yml Show resolved Hide resolved
@kevin940726 kevin940726 mentioned this pull request Oct 21, 2022
Merged
alexstine
alexstine approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevin940726 kevin940726 merged commit 688f392 into trunk Oct 21, 2022
@kevin940726 kevin940726 deleted the fix/uploading-failure-artifacts branch October 21, 2022 15:37
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexstine alexstine alexstine approved these changes

@talldan talldan Awaiting requested review from talldan

Assignees

@kevin940726 kevin940726

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 14.5
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin940726 @alexstine